Fix Manifest file creation for JsonArray with single element #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix single object array to object conversion
abhishekkumams
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
seantleonard,
severussundar and
tarazou9
as code owners
abhishekkumams
changed the title
ayush3797
approved these changes
Dec 2, 2022
seantleonard
reviewed
Dec 2, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Some comments about syntax
…a-api-builder into abhishekkumams-patch-1
seantleonard
approved these changes
Dec 2, 2022
Aniruddh25
approved these changes
Dec 3, 2022
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM only if we confirmed SWA CLI is already accepting this modified manifest file from object to array?
Aniruddh25
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
@()which is the correct way to define Arrays in powershell instead of using'[]'and converting to jsonArray.How was this tested?