Skip to content

Fix Manifest file creation for JsonArray with single element #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 3, 2022
Merged

Fix Manifest file creation for JsonArray with single element #978

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
073b2f7
Update create_manifest_file.ps1
abhishekkumams Nov 13, 2022
ca200a5
Update create_manifest_file.ps1
abhishekkumams Nov 13, 2022
b250b66
enabling pwsh
abhishekkumams Nov 13, 2022
e3e8762
Merge branch 'main' into abhishekkumams-patch-1
abhishekkumams Nov 24, 2022
1fc1d4e
testing changes
abhishekkumams Nov 24, 2022
2afe327
testing
abhishekkumams Dec 2, 2022
7da5e76
testing
abhishekkumams Dec 2, 2022
18c02e6
testing
abhishekkumams Dec 2, 2022
ef7dec5
testing
abhishekkumams Dec 2, 2022
e51240f
testing
abhishekkumams Dec 2, 2022
0afadec
testing
abhishekkumams Dec 2, 2022
67f4080
using json array directly
abhishekkumams Dec 2, 2022
0b7f0de
Merge branch 'main' into abhishekkumams-patch-1
abhishekkumams Dec 2, 2022
f0150a0
testing
abhishekkumams Dec 2, 2022
66a2643
Merge branch 'abhishekkumams-patch-1' of https://github.com/Azure/dat…
abhishekkumams Dec 2, 2022
b75d09b
fixing pipe issue
abhishekkumams Dec 2, 2022
717a698
fixing url
abhishekkumams Dec 2, 2022
9b77c70
Merge branch 'main' into abhishekkumams-patch-1
seantleonard Dec 2, 2022
0a24a06
Merge branch 'main' into abhishekkumams-patch-1
abhishekkumams Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions create_manifest_file.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ $latestBlock = $ExecutionContext.InvokeCommand.ExpandString($latestBlock) | Conv

# Adding new block to the top of the list of released versions.
# TODO: To use the data from the current manifest file and update it.
$versionArray = '[]' | ConvertFrom-Json
$versionArray = @()
$versionArray += $latestBlock

# Removing the oldest version if total count exceeds the max permissible count
Expand All @@ -80,5 +80,5 @@ if($versionArray.Length -gt $maxVersionCount){

# Updating the manifest file
# Keeping Depth as 4, as by default ConvertTo-Json only support conversion till depth 2.
$versionArray | ConvertTo-Json -Depth 4 | Out-File $BuildOutputDir/dab-manifest.json
ConvertTo-Json -Depth 4 $versionArray | Out-File $BuildOutputDir/dab-manifest.json