Adding options section in data-source and removing database specific sections #980
+185
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sections from config- except cosmos
ayush3797
changed the title
ayush3797
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
seantleonard,
severussundar and
tarazou9
as code owners
jarupatj
approved these changes
Nov 17, 2022
Aniruddh25
reviewed
Nov 18, 2022
Aniruddh25
approved these changes
Nov 18, 2022
severussundar
approved these changes
Nov 21, 2022
severussundar
deleted the
dev/agarwalayush/consolidatingDataSourceSection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Fixes #961 as per this rfc #935 (for quick reference refer to this: #935 (comment)).
What is this change?
data-sourcesection.optionssection which will be present in thedata-sourcesection of the config. This will have the additional properties which are database specific. In case of cosmos db, it's safe to say that it will serve the purpose of the "cosmos" section that we used to have.cosmosdb_nosqlandcosmosdb_postgresql.cosmoswill be removed once the code changes are made on the engine side. This is not removed yet to be backwards compatible so that the engine code doesn't fail.How was this tested?