Skip to content

Conversation

@ayush3797
Copy link
Contributor

@ayush3797 ayush3797 commented Nov 22, 2022

Why make this change?

As a follow up to this PR: #980, changing the property names cosmos-container and cosmos-database to cosmosdb_nosql-container and cosmosdb_nosql-database respectively so that the names fall in sync with the cosmosdb_nosql database-type.

What is this change?

Renaming of the options used in dab init command and the corresponding properties in Options class.

How was this tested?

No tests required, just refactoring work.

@ayush3797 ayush3797 self-assigned this Nov 23, 2022
@ayush3797 ayush3797 merged commit 93e7d96 into main Nov 23, 2022
@ayush3797 ayush3797 deleted the dev/agarwalayush/renamingCosmosPropertiesInDabInitCmd branch November 23, 2022 04:18
@ayush3797 ayush3797 linked an issue Nov 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename cosmos specific properties in CLI

4 participants