-
Notifications
You must be signed in to change notification settings - Fork 288
Create binaries without config files #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create binaries without config files #981
Conversation
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few questions, otherwise LGTM.
jarupatj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to have better PR descriptions. Some comments that you replied to me should have been in the PR description since the beginning.
PR description should explain "why" you are doing what you are doing. Right now, it just describes "what".
Why make this change?
What is this change?
dab-config.jsonfile is removedTestHelperfor unit tests that require the config jsonHow was this tested?
Sample Request(s)