Skip to content

Conversation

@Aniruddh25
Copy link
Collaborator

Why make this change?

  • Closes Binplace the json schema with the release artifacts #956
  • After the doing the file transform to set the version number of json schema = build version, we are currently not binplacing it in the artifacts so there is no final schema generated. This schema is required for releasing for ease of config generation for our developers.

What is this change?

  • Adds reference to dab.draft.schema.json in the Cli.csproj so it gets binplaced with CopyAlways upon packaging/building
  • Explicitly copy it to the artifacts as well so as to be pushed to the github release page without requiring extraction from nuget package. It will also be available in the nuget/zip packages.
  • Also updated the version location to include the url where this schema will be hosted upon release. The url https://datapaibuilder.azureedge.net/schemas/vmajor.minor.patch-alpha/dab.draft.schema.json
    is not valid at time of generation of file but would become valid after the release is done. We will need to update the url once we move out of alpha releases.

How was this tested?

  • Triggered a build on this branch and ensured the schema file was binplaced.

ayush3797
ayush3797 previously approved these changes Nov 24, 2022
@ayush3797 ayush3797 dismissed their stale review November 24, 2022 11:04

Enabling merge

@Aniruddh25 Aniruddh25 enabled auto-merge (squash) November 24, 2022 23:13
@Aniruddh25 Aniruddh25 merged commit 306ac69 into main Nov 25, 2022
@Aniruddh25 Aniruddh25 deleted the dev/anmunde/binplaceJsonSchema branch November 25, 2022 07:33
@Aniruddh25 Aniruddh25 linked an issue Dec 6, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binplace the json schema with the release artifacts JSON Schema version

5 participants