Skip to content

changes to support gradle wrapper and defaults#218

Merged
hsubramanianaks merged 7 commits intoAzure:mainfrom
hsubramanianaks:gradle-wrapper
Jul 7, 2023
Merged

changes to support gradle wrapper and defaults#218
hsubramanianaks merged 7 commits intoAzure:mainfrom
hsubramanianaks:gradle-wrapper

Conversation

@hsubramanianaks
Copy link
Contributor

@hsubramanianaks hsubramanianaks commented Jun 26, 2023

Description

This PR is to include gradle wrapper to draft flow and detect the defaults from build.gradle for java projects.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕️🚀 Looks good to my eyes, also seems associated with #214 which I think was reviewed before.

@Tatsinnit Tatsinnit requested a review from davidgamero June 26, 2023 21:35
@Tatsinnit Tatsinnit added the enhancement New feature or request label Jun 26, 2023
@hsubramanianaks hsubramanianaks force-pushed the gradle-wrapper branch 3 times, most recently from 88d2aec to caa1658 Compare June 30, 2023 15:01
Signed-off-by: Hariharan Subramanian <hsubramanian@microsoft.com>
Signed-off-by: Hariharan Subramanian <hsubramanian@microsoft.com>
Signed-off-by: Hariharan Subramanian <hsubramanian@microsoft.com>
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a review just for testing purposes.

Copy link
Contributor Author

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a comment to run tests.

@hsubramanianaks hsubramanianaks merged commit d419927 into Azure:main Jul 7, 2023
@hsubramanianaks hsubramanianaks deleted the gradle-wrapper branch July 7, 2023 15:08
@Tatsinnit Tatsinnit mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants