Skip to content

Integrating Deployment templates into new generic handler#393

Merged
bfoley13 merged 15 commits intomainfrom
brfole/handler-integration
Oct 9, 2024
Merged

Integrating Deployment templates into new generic handler#393
bfoley13 merged 15 commits intomainfrom
brfole/handler-integration

Conversation

@bfoley13
Copy link
Copy Markdown
Member

@bfoley13 bfoley13 commented Oct 7, 2024

Description

This migrates the Deployment templates into the new Generic Template Handler. Non-breaking migration that results in same file output as before through CLI or package usage.

Added DeepCopy support for Template/DraftConfig.
Added filename override handling

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Local Tests
  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bfoley13 bfoley13 marked this pull request as ready for review October 8, 2024 15:30
Copy link
Copy Markdown
Contributor

@Vidya2606 Vidya2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread cmd/info.go Outdated
Comment thread example/deployment.go
Comment thread example/deployment.go
Comment thread pkg/handlers/deployment_test.go Outdated
Comment thread cmd/create.go
Comment thread pkg/config/draftconfig.go
Comment thread pkg/config/draftconfig.go
Copy link
Copy Markdown
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you for kind ping, left few suggestions, rest looks awesome!! I am sure other folks will add anything if I've missed. Thanks heaps.

@bfoley13 bfoley13 enabled auto-merge (squash) October 9, 2024 13:15
@bfoley13 bfoley13 merged commit 073e184 into main Oct 9, 2024
@bfoley13 bfoley13 deleted the brfole/handler-integration branch October 9, 2024 17:13
Vidya2606 pushed a commit to Vidya2606/draft that referenced this pull request Oct 15, 2024
@bfoley13 bfoley13 mentioned this pull request Oct 22, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants