Skip to content

Migrating "Addons" to generic handler#406

Merged
bfoley13 merged 8 commits intomainfrom
brfole/addons
Oct 21, 2024
Merged

Migrating "Addons" to generic handler#406
bfoley13 merged 8 commits intomainfrom
brfole/addons

Conversation

@bfoley13
Copy link
Copy Markdown
Member

Description

This migrates the ingress template to the generic handler. There are some CLI specific logic that will be moved to cmdhelpers for now until we plan out a path for better CLI handling.

The necessary fields were added to the ingress draft.yaml with the defaults being added to keep the same CLI experience.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Comment thread pkg/cmdhelpers/addon_helpers.go
@bfoley13 bfoley13 marked this pull request as ready for review October 17, 2024 18:59
@bfoley13 bfoley13 enabled auto-merge (squash) October 17, 2024 19:45
Comment thread cmd/update.go
Copy link
Copy Markdown
Member

@bosesuneha bosesuneha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread pkg/handlers/template_test.go
@bfoley13 bfoley13 merged commit 52ce052 into main Oct 21, 2024
@bfoley13 bfoley13 deleted the brfole/addons branch October 21, 2024 15:18
@bfoley13 bfoley13 mentioned this pull request Oct 22, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants