Skip to content

Conversation

@davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Nov 12, 2024

Description

Changes in setup-gh command:

  • Centralize Credentials management in AzClient
  • Abstract AzClient out of the SetupCommand
  • Provide a default app name of "-workflow"
  • Use the Select Prompt for Tenant and ResourceGroup
  • Autofill gh repo name default value using gh cli
  • Allow overriding validators (gh repo/az cli validity checks)
  • Update Select Searcher to allow matching out-of-order terms (space delimited, case-insensitive)

@davidgamero davidgamero marked this pull request as ready for review November 14, 2024 22:46
@Tatsinnit Tatsinnit added the enhancement New feature or request label Nov 15, 2024
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Looks good to me, thank you so much for this, I've added folks who have touched this in past just as eyeball and I am sure you have taken care of the rest!! Thank you for the ping as well.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕️❤️

@davidgamero davidgamero force-pushed the davidgamero/setup-gh-selectors branch from b994d34 to ffb3838 Compare November 19, 2024 20:21
Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be nice to have this in!

@bfoley13 bfoley13 merged commit 04c6cba into main Nov 20, 2024
149 checks passed
@bfoley13 bfoley13 deleted the davidgamero/setup-gh-selectors branch November 20, 2024 14:22
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 13, 2024
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 16, 2024
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 19, 2024
audrastump pushed a commit to audrastump/draft that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants