Skip to content

Conversation

@davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Mar 12, 2025

Description

In order to better serve automated and batch workflows, as well as the wrapped-binary consumption patter, i propose adding a new interactive flag that will error on stderr instead of interactively prompting.

this will open up automation options like running in github actions with better error handing

Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@davidgamero davidgamero force-pushed the davidgamero/interactive-flag branch 2 times, most recently from 1d694a4 to c5740e4 Compare March 13, 2025 22:12
@davidgamero davidgamero force-pushed the davidgamero/interactive-flag branch from c912a8d to cf01d86 Compare March 14, 2025 02:56
@davidgamero davidgamero marked this pull request as ready for review March 14, 2025 03:25
@davidgamero davidgamero enabled auto-merge (squash) March 14, 2025 14:26
Copy link
Contributor

@ReinierCC ReinierCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you so much for the ping and these changes, beside a minor suggestion looks great! We can always do extractions of string to more common place config way latter.

@Tatsinnit Tatsinnit added the enhancement New feature or request label Mar 14, 2025
@davidgamero davidgamero merged commit 462eeaa into Azure:main Mar 14, 2025
145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants