Update DurableTask.ApplicationInsights and DurableTask.AzureStorage Version#1172
Merged
Update DurableTask.ApplicationInsights and DurableTask.AzureStorage Version#1172
Conversation
cgillum
approved these changes
Oct 14, 2024
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
The code change looks good. However, I see that the "Build & Sign" pipeline failed with what looks like an ESRP authentication issue. However, this doesn't seem related to the code change, so I don't consider it a blocker for this PR.
Collaborator
Author
Thanks for the review, Chris! The pipeline failed because I attempted to create the package for the bug bash using our old DevOps pipelines. Therefore, we don't need to worry about that failure. :) |
nytian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled.
DurableTask.ApplicationInsights v0.1.6 -> v2.0.0 as it uses DurableTask.Core v3.0.0.
DurableTask.AzureStorage v2.0.0- v2.0.1 for new changes in #1159