-
Notifications
You must be signed in to change notification settings - Fork 325
Adding new logic for extended sessions to enable the DTS use-case #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -295,6 +295,7 @@ async Task OnProcessWorkItemSessionAsync(TaskOrchestrationWorkItem workItem) | |
| "OnProcessWorkItemSession-Release", | ||
| $"Releasing extended session after {processCount} batch(es)."); | ||
| this.concurrentSessionLock.Release(); | ||
| await workItem.Session.EndSessionAsync(); | ||
| } | ||
|
sophiatev marked this conversation as resolved.
|
||
| } | ||
| } | ||
|
|
@@ -552,10 +553,6 @@ protected async Task<bool> OnProcessWorkItemAsync(TaskOrchestrationWorkItem work | |
| orchestratorMessages.AddRange(subOrchestrationRewindMessages); | ||
| workItem.OrchestrationRuntimeState = newRuntimeState; | ||
| runtimeState = newRuntimeState; | ||
|
sophiatev marked this conversation as resolved.
|
||
| // Setting this to true here will end an extended session if it is in progress. | ||
| // We don't want to save the state across executions, since we essentially manually modify | ||
| // the orchestration history here and so that stored by the extended session is incorrect. | ||
| isRewinding = true; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this assignment no longer needed?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was leftover from a previous PR where I added rewind support. I realized that I had moved where this was set to here but forgot to remove this redundant setting later on. |
||
| break; | ||
| default: | ||
| throw TraceHelper.TraceExceptionInstance( | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.