[eno] Added telemetry library and logging for synthesizer in eno #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There's already similar functionality in this controller: https://github.com/Azure/eno/blob/main/internal/controllers/composition/statuslogger.go Personally I'd recommend avoiding the abstraction and just writing a dedicated controller for logging each type, since the total number of logging controllers will never be > 3. But feel free to continue with this approach - it will work either way. EDIT: sent too soon 🤣 If you continue in the direction of a generic logging controller just make sure to replace the existing statuslogger so things are consistent across CR types. |
xiazhan
reviewed
Nov 11, 2025
tilnl
approved these changes
Nov 11, 2025
ruinan-liu
commented
Nov 12, 2025
Contributor
Author
ruinan-liu
left a comment
ruinan-liu
left a comment
There was a problem hiding this comment.
replied to comments
xiazhan
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added below fields to EnoEvents table
synthName, synthUrl, synthCreationTimestamp