[Eno] Add inter composition ordering by ruinan-liu · Pull Request #581 · Azure/eno

ruinan-liu · 2026-03-19T20:58:47Z

uses dependsOn to add inter composition ordering

api/v1/config/crd/eno.azure.io_compositions.yaml

internal/controllers/scheduling/controller.go

internal/controllers/scheduling/dependency.go

internal/controllers/symphony/controller.go

internal/manager/indices.go

ruinan-liu

Reply to comments

internal/controllers/composition/controller.go

internal/controllers/reconciliation/controller.go

internal/controllers/scheduling/controller.go

internal/controllers/symphony/controller.go

ruinan-liu

Replied to comments

internal/controllers/composition/controller.go

ruinan-liu

Respond to comment

internal/controllers/composition/controller.go

xiazhan · 2026-04-03T21:01:38Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

ruinan-liu · 2026-04-03T22:09:32Z

DependencyStatus with CircularDependency reason is never cleared after cycle resolution
Fixed, updated in code
No DependencyStatus update when dependencies aren't ready (scheduling controller logs + continues silently)
Currently it is doing in compositionController
// This means that dependencies exists and no synthesis started showing WaitingOnDependencies
if len(comp.Spec.DependsOn) > 0 {
status.Status = apiv1.WaitingOnDependenciesReason
return status
}
path.Join with empty namespace produces wrong key for standalone Compositions
Not Applicable, there will always be a namespace
Circular dependency status patch errors are logged but swallowed (no requeue)
Currently are not applicable, the scheduling controller runs on every composition/synthesizer change via SingleEventHandler, so the next reconcile will naturally retry the patch. The status will eventually converge.
newDependencyEventHandler predicate allows updates through but handler only enqueues on deletion
Changed to only allow update when a composition is in deletionTimestamp given it's only used to unblock dependency deletion
CompositionDependency.Namespace comment says "dependent" but means "dependency" (wrong API doc)
Done
Doc comment says buildComsByKey but function is named buildCompsByKey
done. Fixed

internal/controllers/reconciliation/controller.go

xiazhan · 2026-04-05T17:41:54Z

internal/controllers/symphony/controller.go

 	logger.Info("reconciling reverse - checking for compositions to delete", "variationCount", len(symph.Spec.Variations), "existingCompositionCount", len(comps.Items), "symphonyDeleting", symph.DeletionTimestamp != nil)
 	// Delete compositions when their synth has been removed from the symphony
 	existingBySynthName := map[string][]*apiv1.Composition{}
 	for _, comp := range comps.Items {


Should sort the comps.Items with dependency graph before traversing. So we can complete the creation/deletion in O(n). During the sorting, we can detect the circular dependency as well.

xiazhan · 2026-04-05T17:43:38Z

internal/controllers/symphony/controller.go

+	}
+
 	// Sync forward (create/update)
 	for _, variation := range symph.Spec.Variations {


The same comment. Should sort the comps.Items with dependency graph before traversing. So we can complete the creation/deletion in O(n). During the sorting, we can detect the circular dependency as well.

The pr is too big for an effective review. Please split into multiple prs with each targeting one specific controller.

xiazhan · 2026-04-05T17:53:13Z

internal/controllers/scheduling/controller.go

+
 	var inFlight int
 	var op *op
 	for _, comp := range comps.Items {


Sort it with dependency graph before traversing.

Part1 of breaking down of the larger PR: #581 Adding API changes in `Composition` and `Symphony` Specs.

ruinan-liu added 9 commits March 19, 2026 13:57

Initial commit on composition ordering

4d89eee

revert back to use 1.24

91a07dd

Fixing assumptions and adding test

7bb61ea

Updating controller-gen version

b78968b

cleanup code

4972c63

remove unnecessary files

27d966c

Fixing unit test

3474bce

Code review fixes

c0998ac

Remoing 2 test files

08007da

ruinan-liu marked this pull request as ready for review March 24, 2026 18:42

ruinan-liu requested review from robbiezhang, tilnl and xiazhan as code owners March 24, 2026 18:42

Updating tests

806b806

xiazhan reviewed Mar 25, 2026

View reviewed changes

api/v1/config/crd/eno.azure.io_compositions.yaml Outdated Show resolved Hide resolved

xiazhan reviewed Mar 26, 2026

View reviewed changes

ruinan-liu added 2 commits March 26, 2026 11:42

Fixing delete timeout issue

578f31c

Resolving comments

e1ff9bb

ruinan-liu commented Mar 26, 2026

View reviewed changes

ruinan-liu added 4 commits March 26, 2026 14:06

Fixing unit tests

4f1a23d

Adding Podman build commands

d582464

Adding more conditions to failOpen

e52fcef

fix comments

9ae815c

ruinan-liu requested a review from xiazhan March 30, 2026 22:52