chore: Add UT to ensure Arc charts are parseable #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds unit tests for the Arc member agent Helm charts to ensure that all chart templates render to valid YAML. This is the first Helm chart test in the repository and validates that templates parse and render correctly with maximal configuration values to activate all conditional paths. The test helps prevent misconfigured YAML from being deployed.
- Adds comprehensive unit test for Helm template rendering validation
- Implements custom mock functions for Helm/Sprig template functions
- Tests all non-helper templates in the charts directory
Ealianis
approved these changes
Dec 15, 2025
Contributor
Ealianis
left a comment
Ealianis
left a comment
There was a problem hiding this comment.
This makes sense to add as we don't have E2E tests for when the helm chart is published. Our Internal E2Es join arc clusters after the extension has been created.
In the future, we can remove this once we have our own repo and E2E tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a UT that ensures that the Arc member agent charts are parseable to avoid any misconfigured yaml
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer