fix: Remove unused fields in membership API #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
minhng22
reviewed
Jun 28, 2022
| @@ -1,86 +0,0 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
I am curious why do we remove this rbac?
Contributor
Author
There was a problem hiding this comment.
There is no use for this file. It was auto-generated by kubebuilder and was only for reference to build the helm charts
Arvindthiru
reviewed
Jun 28, 2022
| } | ||
|
|
||
| // MembershipSpec defines the desired state of the member agent installed in the member cluster. | ||
| type MembershipSpec struct { |
Contributor
There was a problem hiding this comment.
what is the name of the memberShip?
Arvindthiru
pushed a commit
to Arvindthiru/fleet-public
that referenced
this pull request
Jul 10, 2025
) Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.12.1 to 2.12.2. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@002fdce...6c439dc) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.12.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
hubURLandmemberClusterNamefields from Membership API as they are not used. Both fields will be passed as environment variables to the member-agent helm chart.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer