chore: Backport v20260428#1299
Merged
michaelawyu merged 12 commits intoAzure:mainfrom Apr 30, 2026
Merged
Conversation
…st-privilege ClusterRoles (Azure#574) Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
…e#666) * chore: clean up resource watcher tests and rename detector file - Implement fakeController.Run as a no-op; the stub previously panicked with "implement me", but the fake is never started in tests and only exists to satisfy the controller.Controller interface and record Enqueue calls. - Add table-driven TestChangeDetector_dynamicResourceFilter covering reserved/skipped namespaces, kube-root-ca.crt filtering by ShouldPropagateObj, tombstones from informer cache deletion, cluster-scoped unstructured input, and the typed-object bypass. - Rename change_dector.go to change_detector.go to fix the long-standing typo in the filename. Partially addresses Azure#642. The remaining TODO at change_detector.go:107 (pre-built built-in resources map) is left as a follow-up because the optimization is open-ended in scope and conflates two ideas (skipping cache-sync wait and detecting built-in GVRs). Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com> * chore: address review feedback Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com> * test: add coverage for newFilteringHandlerOnAllEvents Address codecov/patch shortfall on PR Azure#666: the handler-builder helper had no direct unit test, so the signature-only change to it dropped patch coverage. Add a table-driven test that exercises each of the six (event x filter-result) combinations and asserts callback firing matches the filter outcome. Also Boy-Scout the two remaining `interface{}` declarations in this file to `any`. Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com> --------- Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com> Co-authored-by: Claude Code <noreply@anthropic.com>
ytimocin
previously approved these changes
Apr 28, 2026
ytimocin
force-pushed
the
backport-v20260428
branch
from
7375b51 to
574587a
Compare
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
ytimocin
force-pushed
the
backport-v20260428
branch
from
574587a to
04559e6
Compare
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
jwtty
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
kubefleet-dev/kubefleet@6d67e7e (cncf/main) chore: clean up resource watcher tests and rename detector file (kubefleet-dev/kubefleet#666)
kubefleet-dev/kubefleet@b548d9b fix: disable rolling out fleet namespace staged rollout custom resources (kubefleet-dev/kubefleet#631)
kubefleet-dev/kubefleet@2086d2e chore: bump aquasecurity/trivy-action from 0.35.0 to 0.36.0 (kubefleet-dev/kubefleet#624)
kubefleet-dev/kubefleet@90929d5 chore: bump step-security/harden-runner from 2.18.0 to 2.19.0 (kubefleet-dev/kubefleet#623)
kubefleet-dev/kubefleet@1c82b51 feat: determine failure type when possible for update run (kubefleet-dev/kubefleet#621)
kubefleet-dev/kubefleet@daf3165 feat: add kubebuilder RBAC markers and replace cluster-admin with least-privilege ClusterRoles (kubefleet-dev/kubefleet#574)
kubefleet-dev/kubefleet@aa840c6 feat: have update run skip a stage with no clusters (kubefleet-dev/kubefleet#609)
kubefleet-dev/kubefleet@5c572cf fix: add pod/rs guardrail check consistently (kubefleet-dev/kubefleet#682)