Skip to content

fix: Simplify the flow of MC controller #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
circy9 merged 10 commits into from
Aug 4, 2022
Merged

fix: Simplify the flow of MC controller #220

circy9 merged 10 commits into from
Aug 4, 2022

Conversation

@circy9
Copy link
Contributor

@circy9 circy9 commented Aug 4, 2022 •
edited
Loading

Simplify the flow of MC controller. Will do manual testing later.

Here are the test results:
https://msazure.visualstudio.com/CloudNativeCompute/_wiki/wikis/CloudNativeCompute.wiki/355835/liqian-test-hub-agent

@circy9 circy9 requested a review from ryanzhang-oss August 4, 2022 04:58
Arvindthiru
Arvindthiru reviewed Aug 4, 2022
View reviewed changes
Arvindthiru
Arvindthiru reviewed Aug 4, 2022
View reviewed changes
@Arvindthiru
Copy link
Contributor

Arvindthiru commented Aug 4, 2022

Clarification: So with this refactor all the resources like Namespace, role, role binding & Internal member cluster will exist until we delete the member cluster CR right ?

@circy9
Copy link
Contributor Author

circy9 commented Aug 4, 2022

Yes

Arvindthiru
Arvindthiru approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@Arvindthiru Arvindthiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed

fleet/pkg/controllers/membercluster/membercluster_controller_integration_test.go

Lines 97 to 103 in a47a01d

heartBeatReceivedCondition := metav1.Condition{
Type: fleetv1alpha1.ConditionTypeInternalMemberClusterHeartbeat,
Status: metav1.ConditionTrue,
Reason: "InternalMemberClusterHeartbeatReceived",
ObservedGeneration: imc.GetGeneration(),
}
imc.SetConditions(joinedCondition, heartBeatReceivedCondition)
,

But I can remove when I make changes to accommodate the heartbeat api

@circy9 circy9 merged commit 8306481 into main Aug 4, 2022
@zhiying-lin zhiying-lin deleted the liqian/memberclustercontroller branch August 16, 2023 08:40
@jwtty jwtty mentioned this pull request Aug 27, 2025
Merged
1 task
michaelawyu pushed a commit to michaelawyu/fleet that referenced this pull request Aug 28, 2025
@zhiying-lin
fix: fix the resource change bug (Azure#220)
f6c14d1 
---------

Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arvindthiru Arvindthiru Arvindthiru approved these changes

@ryanzhang-oss ryanzhang-oss Awaiting requested review from ryanzhang-oss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@circy9 @Arvindthiru