Skip to content

refactor: adjust channel usage#31

Merged
ryanzhang-oss merged 2 commits into
Azure:mainfrom
ryanzhang-oss:refine-channel
May 31, 2022
Merged

refactor: adjust channel usage#31
ryanzhang-oss merged 2 commits into
Azure:mainfrom
ryanzhang-oss:refine-channel

Conversation

@ryanzhang-oss
Copy link
Copy Markdown
Contributor

@ryanzhang-oss ryanzhang-oss commented May 31, 2022

Description of your changes

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Not tested, we need to create

Special notes for your reviewer

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #31 (a32bac1) into main (6ec3420) will increase coverage by 26.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #31       +/-   ##
===========================================
+ Coverage   52.63%   79.57%   +26.94%     
===========================================
  Files           1        1               
  Lines          38      142      +104     
===========================================
+ Hits           20      113       +93     
- Misses         18       29       +11
Impacted Files Coverage Δ
...trollers/membercluster/membercluster_controller.go 79.57% <0.00%> (+26.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec3420...a32bac1. Read the comment docs.

helayoty
helayoty reviewed May 31, 2022
View reviewed changes
Comment thread pkg/controllers/membership/membership_controller.go Outdated
minhng22
minhng22 reviewed May 31, 2022
View reviewed changes
Comment thread pkg/controllers/membership/membership_controller.go
helayoty
helayoty reviewed May 31, 2022
View reviewed changes
Comment thread pkg/controllers/membership/membership_controller.go
@ryanzhang-oss ryanzhang-oss changed the title adjust channel usage refactor: adjust channel usage May 31, 2022
helayoty
helayoty reviewed May 31, 2022
View reviewed changes
Comment thread pkg/controllers/membership/membership_controller.go
helayoty
helayoty reviewed May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

Comment thread pkg/controllers/memberinternalmembercluster/member_controller.go
@helayoty helayoty mentioned this pull request May 31, 2022
Closed
helayoty
helayoty approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

minhng22
minhng22 approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@minhng22 minhng22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanzhang-oss ryanzhang-oss merged commit 9dc6266 into Azure:main May 31, 2022
@ryanzhang-oss ryanzhang-oss deleted the refine-channel branch August 22, 2022 22:40
Arvindthiru pushed a commit to Arvindthiru/fleet-public that referenced this pull request Apr 28, 2025
@jwtty
fix: fix rollout controller not rollout when type is changed from Ext…
9c67ff9 
…ernal to RollingUpdate (Azure#31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minhng22 minhng22 minhng22 approved these changes

@helayoty helayoty helayoty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanzhang-oss @minhng22 @helayoty