feat: disable placing atm related resources #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| r.AddGroup(metricsV1beta1.GroupName) | ||
| r.AddGroupVersionKind(corev1PodGVK) | ||
| r.AddGroupVersionKind(corev1NodeGVK) | ||
| // disable networking resources |
Contributor
There was a problem hiding this comment.
should add the entire fleet-network group instead of one by one
Contributor
Author
There was a problem hiding this comment.
it depends. for example, the serviceExport and mcs should be placed to the members.
Validated that we don't support disabling all networking gvk but excluding the serviceExport and mcs today. Could be a future improvement task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The fix is needed for supporting new networking feature
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer