fix(release): always publish stable to VS Code Marketplace#125
Conversation
Drop the odd-minor / even-minor convention from the marketplace publish step. It was triggering 'Cannot use --pre-release flag with a package that was not packaged as pre-release' on v0.1.0 because the VSIX is always packaged without --pre-release. The odd/even minor scheme is an opt-in convention used by some Microsoft extensions, not a marketplace requirement. We publish every release as a stable marketplace release; semver pre-release suffixes (e.g. 0.1.0-rc.1) continue to skip marketplace publish entirely.
There was a problem hiding this comment.
Pull request overview
This PR fixes the VS Code Marketplace publish failure in the release workflow by removing the odd/even-minor prerelease branching and always publishing Marketplace releases as stable (while still skipping Marketplace publish for semver prerelease-suffix versions like 0.1.0-rc.1).
Changes:
- Remove minor-parity logic that conditionally added
vsce publish --pre-release. - Always run
vsce publishas a stable (Release channel) publish for non-prerelease semver versions. - Keep the existing guard to skip Marketplace publish when the version includes a semver prerelease suffix.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/git-ape-release.yml |
Simplifies Marketplace publishing to always publish stable and avoids --pre-release mismatch with a stable-packaged VSIX. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Review summaryThis PR correctly fixes the v0.1.0 marketplace publish failure by removing the odd/even minor version branching logic. The workflow now always publishes to the stable Marketplace channel, matching how the VSIX is actually packaged (without Correctness
Minor nits (non-blocking)
LGTM — This fix directly addresses the failure and simplifies the workflow by removing the opt-in odd/even convention that wasn't being followed in the packaging step. |
Why
Run https://github.com/Azure/git-ape/actions/runs/26485522294 failed at the
Publish to VS Code Marketplacestep with:For
v0.1.0, the workflow computedMINOR=1→ odd →vsce publish --pre-release, but the VSIX is always packaged without--pre-release, sovscerejected it.The odd-minor / even-minor channel scheme is an opt-in convention used by some Microsoft extensions (Python, etc.), not a Marketplace requirement.
What
0.1.0-rc.1) continue to skip marketplace publish entirely.Follow-up
v0.1.0cannot be re-published with the same version. Cut a new tag (e.g.v0.1.1) after merge to verify the publish path.