Skip to content

from markphillips100 with my change on gitops_event_handler.py#78

Merged
eedorenko merged 5 commits intoAzure:mainfrom
cyberjpb1:multi-config-support
May 7, 2025
Merged

from markphillips100 with my change on gitops_event_handler.py#78
eedorenko merged 5 commits intoAzure:mainfrom
cyberjpb1:multi-config-support

Conversation

@cyberjpb1
Copy link
Copy Markdown
Contributor

This is the multi-config-support from markphillips100 with my change on gitops_event_handler.py

@cyberjpb1
Copy link
Copy Markdown
Contributor Author

@markphillips100 Can you confirm that the PR is OK?

@cyberjpb1
Copy link
Copy Markdown
Contributor Author

cyberjpb1 commented Apr 6, 2025

Since the code was shared with me by markphillips100 (https://github.com/markphillips100/gitops-connector/tree/flux-multi-config-support), I cannot answer the question about the Contributor License Agreement (CLA).

This PR was made at the request of markphillips100. If you do not obtain markphillips100's consent to the Contributor License Agreement (CLA), please delete the code.

@markphillips100
Copy link
Copy Markdown

CLA: I hereby supply my consent to use my code changes. They were not written in the context of any employer. The changes are my own,

@cyberjpb1 cyberjpb1 closed this Apr 6, 2025
@cyberjpb1 cyberjpb1 deleted the multi-config-support branch April 6, 2025 07:53
@cyberjpb1 cyberjpb1 restored the multi-config-support branch April 6, 2025 07:53
@cyberjpb1 cyberjpb1 reopened this Apr 6, 2025
@markphillips100
Copy link
Copy Markdown

@cyberjpb1 only 2 things stand out to me at this point:

  1. No need to include the taskfile.yml, this is just my way of running repetitive console tasks.
  2. The CRD domain example.com likely will need something more specific, and I'd suggest @eedorenko has responsibility for what that should be perhaps.

I wish I was in a position to be able to test out the PR but it's just difficult at the moment so will have to rely on yourself and @eedorenko for that...unless things change for me prior to the PR being merged.

@eedorenko
Copy link
Copy Markdown
Collaborator

lgtm

@cyberjpb1
Copy link
Copy Markdown
Contributor Author

cyberjpb1 commented Apr 23, 2025

@microsoft-github-policy-service agree company="Retraite Québec" for cyberjpb1.

CLA: I hereby supply my consent to use my code changes. They were not written in the context of any employer. The changes are my own, for markphillips100.
Capture d’écran, le 2025-04-23 à 00 21 49

@eedorenko eedorenko merged commit 0f29e9f into Azure:main May 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants