Skip to content

Conversation

@rambohe-ch
Copy link
Collaborator

No description provided.

@rambohe-ch rambohe-ch marked this pull request as draft March 5, 2025 23:17
@rambohe-ch rambohe-ch marked this pull request as ready for review March 6, 2025 01:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (f749848) to head (9e61f8e).

Files with missing lines Patch % Lines
pkg/providers/instance/instance.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   70.45%   69.77%   -0.68%     
==========================================
  Files           4        4              
  Lines         440      450      +10     
==========================================
+ Hits          310      314       +4     
- Misses        112      116       +4     
- Partials       18       20       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…nodeclaim

Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
@Fei-Guo Fei-Guo merged commit 1308cc0 into main Mar 6, 2025
6 checks passed
@Fei-Guo Fei-Guo deleted the fix-instance-gc branch March 6, 2025 04:05
helayoty pushed a commit that referenced this pull request May 14, 2025
…nodeclaim (#212)

Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants