feat: remove crd rbac settings #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
rambohe-ch
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 69.77% 69.77%
=======================================
Files 4 4
Lines 450 450
=======================================
Hits 314 314
Misses 116 116
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fei-Guo
approved these changes
Mar 6, 2025
helayoty
pushed a commit
that referenced
this pull request
May 14, 2025
because webhook is disabled for gpu-provisioner, so rbac settings for crd resource is not needed. Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because webhook is disabled for gpu-provisioner, so rbac settings for crd resource is not needed.