Skip to content

Conversation

@rambohe-ch
Copy link
Collaborator

@rambohe-ch rambohe-ch commented Oct 18, 2025

  • Background:
    Because in latest NodeClaim CRD, spec.NodeClassRef.Group field is not allowed to empty. Then old nodeclaim that created by Kaito(before 0.6.0) can not be deleted by gpu-provisioner. the error as follows:
{"level":"INFO","time":"2025-10-17T15:49:18.350Z","logger":"controller","message":"ensure terminated nodeclaim","controller":"node.termination","controllerGroup":"","controllerKind":"Node","Node":{"name":"aks-ws1f323dc0c-28697582-vmss000000"},"namespace":"","name":"aks-ws1f323dc0c-28697582-vmss000000","reconcileID":"d35356ca-bc33-4bf2-b6b4-11ad2c9c66d3","nodeclaim":"ws1f323dc0c","isInstanceTerminated":false,"error":"NodeClaim.karpenter.sh \"ws1f323dc0c\" is invalid: spec.nodeClassRef.group: Invalid value: \"string\": group may not be empty"}
  • Solution:
    The nodeclaim removal is blocked by patch terminating status for nodeclaim, so we comment these routine and make sure gpu-provisioner can delete old NodeClaim.

…nodeclaim crd changes

Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.63%. Comparing base (9b1a829) to head (12a3859).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files           4        4           
  Lines         491      491           
=======================================
  Hits          337      337           
  Misses        135      135           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fei-Guo Fei-Guo merged commit 87a6818 into main Oct 18, 2025
5 of 6 checks passed
@Fei-Guo Fei-Guo deleted the remove-patch-terminating-status branch October 18, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants