Validate current OS is tier 1 + unit tests#11
Merged
Conversation
mhshami01
reviewed
May 12, 2021
src/azure-iot-edge-installer.sh
Outdated
| if [ "$?" != "0" ] | ||
| then | ||
| echo "This OS is not supported. Exit." | ||
| # log_error "This OS is not supported. Exit." |
Contributor
There was a problem hiding this comment.
We can use the logger now :-) #Resolved
src/azure-iot-edge-installer.sh
Outdated
| is_os_tier1 $ID $VERSION_ID | ||
| if [ "$?" != "0" ] | ||
| then | ||
| log_error "This OS is not supported. Exit." |
Contributor
There was a problem hiding this comment.
nit: should we leave a link to the Tier 1 OS documentation, or show that only two OS are supported today? #Resolved
mhshami01
reviewed
May 13, 2021
src/azure-iot-edge-installer.sh
Outdated
| # attempt to download to a temporary file. | ||
| wget $url_text -q -O $tmp_file | ||
| #wget $url_text -q -O $tmp_file | ||
| cp ../$file_name . |
Contributor
There was a problem hiding this comment.
- I assume this is only temporary :-)
- Please merge with 'main' and use:
cp ../$TOPDIR/$file_name . - nit: replace tabs with spaces :-) #Resolved
mhshami01
reviewed
May 13, 2021
src/azure-iot-edge-installer.sh
Outdated
| source src/utils.sh | ||
| source src/validate-tier1-os.sh | ||
| source utils.sh | ||
| source validate-tier1-os.sh |
Contributor
There was a problem hiding this comment.
- after merging with main, use $TOPDIR/validate-tier1-os.sh #Resolved
mhshami01
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.