Avoid container build by adding /.mariner-toolkit-ignore-dockerenv#7409
Merged
kodiakhq[bot] merged 9 commits intoAzure:mainfrom Dec 20, 2024
Merged
Avoid container build by adding /.mariner-toolkit-ignore-dockerenv#7409kodiakhq[bot] merged 9 commits intoAzure:mainfrom
kodiakhq[bot] merged 9 commits intoAzure:mainfrom
Conversation
gauravIoTEdge
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Azure Linux builds started failing in the past week or so because Azure Linux recently made a change to how they detect container builds (see microsoft/azurelinux#11135), so the trick we employed to force a regular build (even though we're building in a container) stopped working. This change removes the trick and takes the recommended approach of adding
/.mariner-toolkit-ignore-dockerenvto the container.Other changes were also needed to resolve problems that came up while testing this PR:
snap refreshbefore building.To test, I confirmed that the CI Build passes with these changes.
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines