Add workflows for building#4
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
EmJayGee
force-pushed
the
micgrier/fixgsl
branch
9 times, most recently
from
65f8425 to
a5d4a11
Compare
There was a problem hiding this comment.
Please try to think of a better name for this.
What's next long_long_boring_workflow.yml? workflow128.yml?
| @@ -0,0 +1,95 @@ | |||
| # For most projects, this workflow file will not need changing; you simply need | |||
There was a problem hiding this comment.
Can we inherit from a template workflow, instead of copy/paste? In ADO you can, and it is required there for compliance.
| #include <string> | ||
| #include <string_view> | ||
|
|
||
| #ifndef __GNUG__ |
There was a problem hiding this comment.
Please double check at some point, if clang defines this.
| }; | ||
|
|
||
| inline constexpr auto diagnostic_channel_name = L"diagnostic"_sl; | ||
| inline constexpr auto diagnostic_channel_name = L"diagnostic"sv; |
There was a problem hiding this comment.
Are you sure you need inline here?
Isn't inline for non-const really?
| FetchContent_Declare( | ||
| googletest | ||
| GIT_REPOSITORY https://github.com/google/googletest.git | ||
| GIT_REPOSITORY https://github.com/google/googletest.git |
There was a problem hiding this comment.
Googletest works, but GSL does not? Surprising.
| GIT_REPOSITORY "https://github.com/microsoft/GSL" | ||
| GIT_TAG "v4.1.0" | ||
| GIT_TAG "v4.2.0" | ||
| GIT_SHALLOW ON |
There was a problem hiding this comment.
Oh, or you did get it working?
| @@ -0,0 +1,33 @@ | |||
| on: | |||
There was a problem hiding this comment.
So much boilerplate. Ugh. But I know, you are trying, so I approve.
EmJayGee
force-pushed
the
micgrier/fixgsl
branch
from
a5d4a11 to
95021b8
Compare
3 participants
Add workflows for building on multiple platforms - msvc on Windows and clang on Ubuntu.
I tried to add gcc on Ubuntu but it has too many problems with user defined string literals and std::format / std::formatter<> specializations, I couldn't deal with all the problems.