ci(lint): add workflow and taskfiles#182
Conversation
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive CI/CD refactoring by adding a new lint workflow and reorganizing the Taskfile structure. The changes modularize task definitions into domain-specific files, add numerous installation scripts for development tools, and update various configuration files.
Key Changes
- Modularized Taskfile structure with domain-specific includes (azure, golang, markdown, yaml, runtime, internal)
- Added new GitHub Actions lint workflow that runs linting tasks in a matrix for Go, Markdown, and YAML files
- Created installation scripts for various tools (uv, fnm, pwsh, golang, golangci-lint, bicep, azd, az)
- Removed duplicate lint-related jobs from the main CI workflow (consolidated into the new lint workflow)
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Taskfile.yml | Restructured main taskfile to include modular taskfiles, removed old lint/install tasks, added new lint and tools tasks that delegate to included taskfiles |
| .yamlignore | Added ignore patterns for yamllint (terraform, venv, git, node_modules) |
| .taskfiles/yaml.Taskfile.yml | New taskfile for YAML linting using yamllint |
| .taskfiles/scripts/setup_uv.sh | Installation script for uv package manager |
| .taskfiles/scripts/setup_pwsh.sh | Installation script for PowerShell on Linux/macOS |
| .taskfiles/scripts/setup_golang.sh | Installation script for Go runtime |
| .taskfiles/scripts/setup_fnm.sh | Installation script for fnm (Fast Node Manager) |
| .taskfiles/scripts/install_golangci-lint.sh | Installation script for golangci-lint |
| .taskfiles/scripts/install_bicep.sh | Installation script for Azure Bicep |
| .taskfiles/scripts/install_azd.sh | Installation script for Azure Developer CLI |
| .taskfiles/scripts/install_az.sh | Installation script for Azure CLI |
| .taskfiles/runtime.Taskfile.yml | New taskfile for setting up runtime environments (uv, fnm, pwsh, golang) |
| .taskfiles/markdown.Taskfile.yml | New taskfile for markdown linting with markdownlint-cli2 and markdown-table-formatter |
| .taskfiles/golang.Taskfile.yml | New taskfile for Go tool installation and linting |
| .taskfiles/azure.Taskfile.yml | New taskfile for Azure tool installation |
| .taskfiles/_internal.Taskfile.yml | New internal taskfile with reusable installation helpers for various package managers |
| .node-version | Added Node version file specifying version 24 |
| .goreleaser.yml | Removed unnecessary quotes from various string values |
| .github/workflows/lint.yml | New workflow for running linting tasks in a matrix (go, md, yml) |
| .github/workflows/e2e-tests.yaml | Updated Terraform version from 1.10.4 to 1.14.3 |
| .github/workflows/dependency-review.yml | Simplified dependency review action configuration |
| .github/workflows/ci.yml | Removed separate lint-go and lint-markdown jobs (consolidated into lint workflow), added ready_for_review trigger |
| .github/linters/.yamllint.yml | New yamllint configuration file |
| .github/linters/.markdownlint.yml | Removed 'a' from allowed HTML elements |
| .github/linters/.markdownlint-cli2.yaml | Added venv/.venv to ignored paths |
| .devcontainer/devcontainer.json | Downgraded Azure CLI from 2.82.0 to 2.81.0, updated Terraform from 1.10.4 to 1.14.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….yml Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…r tool installation checks Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…allation, add Prettier configuration, and enhance VSCode settings Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…cipals Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…s in DeleteCustomRole Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…stomRole Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…n tests Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
No description provided.