-
Notifications
You must be signed in to change notification settings - Fork 65
Fix #11 - Allow polymorphic serialization from JSON like objects #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested by @vishrutshah on his Monitor issue and all SDK tests ok. |
|
@annatisch I dig inside the msrest code and I realize I re-wrote |
|
@lmazuel - yes I thought there might be some duplication there - I was about to compare them myself :) |
|
@annatisch if you have the time, I pushed an update that should still fix the serialization + the deserialisation at the time (rewriting classify to include both fix). I didn't launch Autorest tests or SDKs yet. |
annatisch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - if the autorest/SDK tests pass should be good to go :)
|
@lmazuel - yup looks like it! :) Yay! |
|
@annatisch last commit was debugged directly with @vishrutshah in peer programming. This allows to accept as key in the dict (serialisation) both the JSON key name and the Python key name. |
Didn't test with Autorest testsuite yet, but since this is JSON-like syntax, I'm pretty sure there is no test in Autorest anyway.