This repository was archived by the owner on Apr 10, 2024. It is now read-only.
Add 'innererror' property bag to CloudErrorData contract#73
Merged
lmazuel merged 2 commits intoAzure:masterfrom Jan 5, 2018
Merged
Add 'innererror' property bag to CloudErrorData contract#73lmazuel merged 2 commits intoAzure:masterfrom
lmazuel merged 2 commits intoAzure:masterfrom
Conversation
lmazuel
approved these changes
Jan 4, 2018
Member
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
Just add a test please and we're good to go.
Thanks for the contribution!
| cloud_exp = self._d(CloudErrorData(), message) | ||
| self.assertEqual(cloud_exp.target, 'query') | ||
| self.assertEqual(cloud_exp.details[0].target, '$search') | ||
| self.assertEqual(cloud_exp.innererror['customKey'], 'customValue') |
Member
There was a problem hiding this comment.
Could you add a str call? You're not testing the __str__ change
self.assertIn("customValue", str(cloud_exp))
Contributor
Author
There was a problem hiding this comment.
Updated the test. Thanks for the quick review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data contract for ARM errors includes
innererrorfield which is a property bag with unspecified contents as per OData 4.0 spec. This field wasn't used by ARM up until now, but recently there was a change related to Azure Policy that makes heavy use of this property bag. It is already deployed in all regions and consumed by Azure Portal, so now would be a good time to support it in SDKs as well.The new errors are generated by the ARM Frontdoor itself, so CloudErrorData seems like the most appropriate contract to include it.