Skip to content

Publish openapi-diff Using ERSP#337

Merged
scbedd merged 7 commits intomainfrom
feature/1es-templates
Jun 18, 2024
Merged

Publish openapi-diff Using ERSP#337
scbedd merged 7 commits intomainfrom
feature/1es-templates

Conversation

@scbedd
Copy link
Copy Markdown
Member

@scbedd scbedd commented Jun 14, 2024

@konrad-jamrozik the consequence of this PR is that you will be able to release oad through an approvable step on the internal build.

That will probably mean creating an internal version of the existing build, but nbd.

Related to Azure/azure-sdk-tools#7941

@scbedd scbedd changed the title Publish Using ERSP Publish openapi-diff Using ERSP Jun 17, 2024
@konrad-jamrozik
Copy link
Copy Markdown

konrad-jamrozik commented Jun 18, 2024

@scbedd so I understand the beginning of these instructions will change:

https://github.com/Azure/openapi-diff/blob/main/CONTRIBUTING.md#publish-the-package

Instead of:

- Ensure you bumped the package version in `openapi-diff` `package.json`.
- Verify [`public.openapi-diff`] passed.
- Use [`js - tools to npm - publish (@azure)`] to publish the package to the public `npm` feed.
- Verify in [`@azure/oad` versions] the package was published.

It will be something like:

- Ensure you bumped the package version in `openapi-diff` `package.json`.
- Verify [`internal.openapi-diff`] passed. <------------- note the change from `public` to `internal` that needs to be created
- Verify in [`@azure/oad` versions] the package was published.

@scbedd
Copy link
Copy Markdown
Member Author

scbedd commented Jun 18, 2024

@scbedd so I understand the beginning of these instructions will change:

https://github.com/Azure/openapi-diff/blob/main/CONTRIBUTING.md#publish-the-package

Instead of:

- Ensure you bumped the package version in `openapi-diff` `package.json`.
- Verify [`public.openapi-diff`] passed.
- Use [`js - tools to npm - publish (@azure)`] to publish the package to the public `npm` feed.
- Verify in [`@azure/oad` versions] the package was published.

It will be something like:

- Ensure you bumped the package version in `openapi-diff` `package.json`.
- Verify [`internal.openapi-diff`] passed. <------------- note the change from `public` to `internal` that needs to be created
- Verify in [`@azure/oad` versions] the package was published.

Basically! I'll update the contributing guide.

@scbedd scbedd merged commit 92878df into main Jun 18, 2024
@scbedd scbedd deleted the feature/1es-templates branch June 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants