Add version-progression linter rule (Rule 7)#4347
Conversation
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/6cf84665-2e09-424f-a485-588f1e3d5ffe Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
|
@copilot There is one fundamental change here. No api-version is allowed to use the same date as any other api-version. That is, there can be no preview version and stable version that have the same date (i.e. 2026-04-28 and 2026-04-28-preview are *not allowed) The dates in api-versions must all be different, and they must be monotonically increasing from the top to the bottom of the Versions enum for a namespace. Please add tests that ensure a violation in this case, please look over tests to see if they need to be updated, please make sure all tests pass, and that you are up to date with the main branch |
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/56954222-0cc6-4475-b605-d35506b0f10f Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Updated in 89d52fe. The rule now enforces that every api-version uses a unique Test updates:
Branch is up to date with |
commit: |
|
@copilot It looks like there are changes to website docs in the ci build. Please ensure you have rebuilt docs from the typespec-azure-resource-manager directory, and ensure that all files are formatted correctly. Also, please pull the latest from main and ensure that only changes associated with this PR are in the PR diff |
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/b5c70eba-383a-475a-bbd3-2df0c45d7126 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Addressed in fe563a0. Ran |
markcowl
left a comment
There was a problem hiding this comment.
As always, make sure to pull the latest from main, make the suggested changes, alter tests to match, ensure that all tests pass, that all files are formatted correctly and that only the changes that are part of this PR are in the PR diff
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/86f51146-dd4b-46e7-b99c-4f7088c9c1f9 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
|
@copilot Please pull the latest from main, rebuild and rebuild the docs for typespec-azure-resource-manager, fix any merge conflicts, verify that all files are correctly formatted and only the changes associated with this PR are in the pr diff |
…iew feedback Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/792a5e9a-e02b-4c1b-b190-6082cc332b41 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Done in 7a4ba03. Pulled latest from main (already merged in earlier commits 1176e13 and 797519c, no new conflicts), reran |
arm-version-progression linter rule (Rule 7)version-progression linter rule (Rule 7)
|
@copilot Please pull the latest from main, rebuild and rebuild the docs for typespec-azure-resource-manager, fix any merge conflicts, verify that all files are correctly formatted and only the changes associated with this PR are in the pr diff |
…st-7-rules # Conflicts: # website/src/content/docs/docs/libraries/azure-resource-manager/reference/linter.md Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/0080d089-1a2c-4907-8e7a-ef90c9e35b78 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Done in c552fca. Merged latest |
|
/azp run typespec-azure - PR Tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Just to make sure I'm working on the right thing — this PR adds the |
maininto the working branch (resolved linter doc conflict by accepting incoming relative-link format)@azure-tools/typespec-azure-resource-managerand rerunpnpm regen-docsversion-progressionrule (file, exports, ruleset entry, docs, chronus changelog) —arm-prefix dropped per reviewisInternalTypeSpecearly-return per reviewdocs/howtos/Versioning/01-about-versioning.mdpnpm format(no changes needed) and verify lint