Optional method params go in method's options type#124
Conversation
...ust/test/cadlranch/payload/json-merge-patch/src/generated/clients/json_merge_patch_client.rs
Show resolved
Hide resolved
.../typespec-rust/test/cadlranch/payload/json-merge-patch/tests/json_merge_patch_client_test.rs
Show resolved
Hide resolved
Could we keep these as TODOs for now? We don't need them and I hate to jump the gun before we decide on Azure/azure-sdk-for-rust#1649. |
Emit associated builder methods for method options. Sort fields in method options types. Include RequestContent<T> as applicable to method options. Include application/merge-patch+json for serde format. Added cadl-ranch json-merge-patch scenario and tests. Note that some tests currently fail due to lack of support for sending JSON nulls. Added latest blob storage tsp.
jhendrixMSFT
force-pushed
the
json-merge-patch
branch
from
15f2d5a to
7bfe51e
Compare
.../typespec-rust/test/cadlranch/payload/json-merge-patch/tests/json_merge_patch_client_test.rs
Show resolved
Hide resolved
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
A few thoughts but nothing blocking.
| rust-version.workspace = true | ||
|
|
||
| [dependencies] | ||
| async-std = { workspace = true } |
There was a problem hiding this comment.
Is this only for tests? It should be in dev-dependencies then. We don't want to be taking a hard dependency on any async runtime. Despite its name, this is not a "std" library and its future is uncertain.
There was a problem hiding this comment.
I will fix this up when I switch tests to tokio::test.
There was a problem hiding this comment.
Ugh I forgot this is more than just a test dependency. We use async_std::task::block_on when implementing TryFrom<Response<T>> on model types.
packages/typespec-rust/test/cadlranch/payload/json-merge-patch/src/generated/models.rs
Show resolved
Hide resolved
2 participants
Emit associated builder methods for method options. Sort fields in method options types.
Include RequestContent as applicable to method options. Include application/merge-patch+json for serde format. Added cadl-ranch json-merge-patch scenario and tests. Note that some tests currently fail due to lack of support for sending JSON nulls. Added latest blob storage tsp.