Merged
Conversation
- criticalsection.h: Replace internal CRITICAL_SECTION struct access with explicit thread ID tracking for IsLockedByCurrentThread() - utility.cpp: Remove deprecated 'register' storage class keyword - Allocs.cpp: Replace deprecated std::wstring_convert/codecvt with WideCharToMultiByte() Windows API - basics.cpp, dynamic_app.cpp: Update deprecated INSTANTIATE_TEST_CASE_P to INSTANTIATE_TEST_SUITE_P (gtest modernization) - testsuite.cpp: Fix signed/unsigned mismatch by using UINT/ULONG types - Remove redundant VLD_FORCE_ENABLE macro definitions (already defined via CMake for non-Debug builds) - Add deep_callstack_test for testing long stack trace handling Both ARM64 and x64 builds now compile with zero warnings.
Enable treating compiler warnings as errors by default (/WX flag). This ensures code quality by preventing warnings from accumulating. Can be disabled with: cmake .. -DVLD_WARNINGS_AS_ERRORS=OFF
- CMakeLists.txt: Change /W3 to /W4 for stricter warnings - crtmfcpatch.h: Suppress C4201 for intentional nameless struct/union - callstack.cpp: Suppress C4127 for third-party cppformat library header - utility.cpp: Wrap VLDVirtualProtect/Restore in #if !defined(_M_ARM64) since they're only used for x86/x64 trampoline detection - utility.cpp, vld.cpp: Fix unused variable warnings with (void) cast All warnings fixed consistently using (void)var pattern for debug-only variables. Both ARM64 and x64 build clean with /W4 /WX.
- Replace ancient cppformat 1.1.0 (March 2015) with {fmt} 12.1.1
- Update callstack.cpp to use modern fmt::format_to_n() API
- Configure fmt library for static runtime to match VLD
- Suppress warnings-as-errors for third-party fmt code
- Eliminates deprecated stdext::checked_array_iterator warnings
STRUNCATE return value from wcstombs_s with _TRUNCATE flag is not an error - it indicates successful truncation. Only assert on actual conversion failures, not on truncated output. This fixes Debug test failures with deep call stacks that exceed the MAXMESSAGELENGTH buffer size.
Set DLL base address to 0x100000000 (4GB) for both x64 and ARM64 platforms for optimal ASLR (Address Space Layout Randomization). Keep 0x03200000 only for x86 (32-bit) which cannot address above 4GB.
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Build System & Warnings
🐛 Bug Fixes
📦 Library Upgrade
🧪 Testing
🏗️ Pipeline (devops.yml)
📊 Stats