Merged
Conversation
- Remove lib/cppformat directory containing copied fmt 12.1.1 files - Add fmt library as git submodule at lib/cppformat - Submodule points to https://github.com/fmtlib/fmt.git at tag 12.1.0
- Remove lib/gtest directory containing copied googletest files - Add googletest as git submodule at lib/gtest (v1.17.0) - Submodule points to https://github.com/google/googletest.git - Update include path in src/tests/CMakeLists.txt for new directory structure
The fmt library triggers C4244 (64-bit to 32-bit conversion) warnings on x86 builds which are treated as errors. Disable this warning for the vld target on x86 only.
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.