publish artifacts, update inno setup script#50
Merged
Conversation
- Publishes build output directory for each architecture and configuration
- Uses succeededOrFailed() condition to capture artifacts even on test failures
- Artifacts named: vld-{arch}-{config} (e.g., vld-x64-Debug, vld-arm64-RelWithDebInfo)
- Add ArchitecturesAllowed=x86 x64 arm64 for all architectures
- Add ArchitecturesInstallIn64BitMode=x64 arm64 for 64-bit install mode
- Update MinVersion to 6.1sp1 (Inno Setup 6.7 format)
- Use {autopf} instead of deprecated {pf}
- Add ARM64 dbghelp files to [Files] section
- Add ARM64 VLD binaries (vld.lib, vld_arm64.dll, vld_arm64.pdb)
- Update ModPathDir() to include ARM64 bin directory
- Update UpdatePaths() to handle ARM64 library path
- Add ARM64 user props modification in ModifyAllProps()
- Updated version in CMakeLists.txt, version.h, vld-setup.iss - Added changelog entry for 2.5.12 release
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Publish the entire build_<arch> folder instead of staging specific files. This includes bin/, lib/, and all build outputs.
a6c7f43 to
0a3927c
Compare
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Now modifies MSBuild user props for all versions: - v4.0 (VS 2010-2015) - v15.0 (VS 2017) - v16.0 (VS 2019) - v17.0 (VS 2022) - v18.0 (VS 2026) - Current (future-proofing) Each version gets Win32, x64, and ARM64 props configured.
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vld.h uses #pragma comment(lib, 'vld_x64.lib') to auto-link, so the lib files must keep their original names, not be renamed to vld.lib.
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
I will add that I've tested the installer on x64/ARM64 with VS2022 and VS2026 and it performs adequately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.