Move our Libraries to only use artifact feed for packages, no Maven Central, Fixes AB#3395409 #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3395409 to an Azure Boards work item. |
github-actions
bot
changed the title
fadidurah
changed the title
p3dr0rv
approved these changes
Dec 10, 2025
shahzaibj
reviewed
Dec 10, 2025
| apply from: rootProject.file("../gradle/versions.gradle") | ||
|
|
||
| repositories { | ||
| // If you don't have access to the package feed below, uncomment the maven central repo |
Contributor
There was a problem hiding this comment.
Why might someone not have access to this feed?
Contributor
Author
There was a problem hiding this comment.
They need an access token for identity division no? What if it's a third party customer? Might not be applicable for android-compelte or broker, but it would be for msal/common. i decided to add it everywhere to be consistent, in case some internal users don't have access to the feed but want to build.
shahzaibj
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received an s360 item asking our libraries to always pull packages from feeds, and not declare mavenCentral as a repository to source dependencies. The feed itself has maven as an upstream. We cannot use AndroidADAL feed as that one has some versions deleted (once a version is deleted from a feed, it cannot be restored, even if an upstream has it). Created a new feed to support this https://identitydivision.visualstudio.com/Engineering/_artifacts/feed/NewAndroid. We pull packages from this new feed, but we still publish our versions to AndroidADAL. The new feed has AndroidADAL as an upstream still, so our existing collection of artifacts is still accessible.
I also took this chance to consolidate the Maven VSTS Username and Access Token fields, which are fields used to authenticate and pull artifacts from the feed. Previously, each library had their own names for these fields with an identifier based on the library in question. These PRs make it so all libraries use the same names,
ENV_VSTS_MVN_CRED_USERNAMEandENV_VSTS_MVN_CRED_ACCESSTOKEN.Validation: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1568877&view=results
AB#3395409