Validate if memory was successfully allocated before continuing. #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| [mutData appendBytes:&size length:sizeof(size)]; | ||
|
|
||
| uint8_t *pbDerivedKey = [self kdfCounterMode:(uint8_t*)_symmetricKey.bytes | ||
| keyDerivationKeyLength:_symmetricKey.length |
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
oldalton
reviewed
Jun 7, 2022
Member
oldalton
left a comment
oldalton
left a comment
There was a problem hiding this comment.
Added a question about NULL vs nil
| fixedInput:(uint8_t*)mutData.bytes | ||
| fixedInputLength:mutData.length]; | ||
|
|
||
| if (pbDerivedKey == nil) |
Member
Author
There was a problem hiding this comment.
You are right, updated.
| ctr = 1; | ||
| keyDerivated = (uint8_t *)malloc(outputSizeBit / 8); //output is 32 bytes | ||
|
|
||
| if (keyDerivated == nil) |
| fixedInput:fixedInput | ||
| fixedInput_length:fixedInputLength]; | ||
|
|
||
| if (dataInput == nil) |
| { | ||
| uint8_t *tmpFixedInput = (uint8_t *)malloc(fixedInput_length + 4); //+4 is caused from the ct | ||
|
|
||
| if (tmpFixedInput == nil) |
oldalton
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add checks to make sure memory allocation is successful before continuing the process.
Suggested in AzureAD/microsoft-authentication-library-for-objc#1497
Type of change
Risk
Additional information