Skip to content
This repository was archived by the owner on Aug 28, 2023. It is now read-only.

Passport-Azure-AD now uses ADAL-Node (plus logging fixes and cleanup)

Choose a tag to compare

@brandwe brandwe released this 23 Jan 23:35
· 299 commits to master since this release

Use of ADAL-Node instead of OAuth2 library from another source.

Fixes #42 Will not allow passing of another logger beyond bunyan. Others may contribute this

Details:

  • The logging now defaults to an ERROR level logging to stderr no matter what
  • The logging now defaults to WARN level logging for everything else, but this can be overridden by a setting passed in to the Strategy if desired
  • This is only for ODIC and Bearer as WS-Fed and SAML are out of support (but anyone is welcome to add it in, should be minimal)

####Fixed issue #76 regarding types not matching in Tests

Details:

  • Fixed the lint issues with the library.
  • Changed the proto deprecation in Error methods such as InternalOpenIDError.prototype = Object.create(Error.prototype); instead of the controversial (and Lint complaining) InternalOpenIDError.prototype.__proto__ = Error.prototype; from previous dev. This should also make execution faster.
  • Removed all TODOs: and NOTEs:

Fixes #78 Lint now passes

Details:

  • Fixed bugs in the waterfall() for odicstrategy.js which was causing issues when loading profiles. This adds back support for B2C and v2 flows (id_token only flows, essentially)
  • This officially resolves issue #78

Fixes #74 - state is now passed.

Fixes #73 - we now pass Req to callback if specified

Details:

  • In addition, I now have a simplified return of (profile, done) as per the convention of Passport libs. (see oidcstrategy.js)
  • In addition, fixed issue with samples so that server validates issue by default in v1 and v2 flows.