Refactor RankedMatch to accept WebSocket as prop#125
Merged
Conversation
…, start AI match directly - RankedMatch now receives ws, connectionStatus, and playerId as props from MultiplayerGame instead of creating its own WebSocket connection - Removed duplicate "Online" connection status indicator from RankedMatch (only the parent MultiplayerGame status bar is shown) - FIND MATCH now starts an AI match immediately client-side without waiting for server matchmaking queue (no 8-second delay) - Relay messages during AI match are routed locally instead of to the server, while non-relay messages (pong, etc.) still pass through https://claude.ai/code/session_01LURnwvyMCMH3jxsucseWiU
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
RankedMatchcomponent to accept WebSocket connection and related state as props from the parentMultiplayerGamecomponent, rather than managing its own connection lifecycle. This simplifies the component and centralizes connection management.Key Changes
MultiplayerGamenow passesws,connectionStatus, andplayerIdas props toRankedMatchqueue_ranked,cancel_ranked, search timer, etc.)RankedMatchranked_queued,ranked_match_found, etc.) since matches are now AI-onlyImplementation Details
useRefto keep the WebSocket prop in sync with effectssendlevel to prevent sending to serverhttps://claude.ai/code/session_01LURnwvyMCMH3jxsucseWiU