Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames the linting workflow step for clarity and adds a minimal Jest test file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The new Jest test uses
expect(true)without a matcher, which will cause the test to fail; add an explicit matcher such asexpect(true).toBe(true)to make the assertion valid.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new Jest test uses `expect(true)` without a matcher, which will cause the test to fail; add an explicit matcher such as `expect(true).toBe(true)` to make the assertion valid.
## Individual Comments
### Comment 1
<location path="app/test/lorem2.test.ts" line_range="1-2" />
<code_context>
+test("Another truthful test", ()=>{
+ expect(true)
+})
\ No newline at end of file
</code_context>
<issue_to_address>
**issue (testing):** Add a matcher to the expectation so the assertion actually runs
`expect(true)` without a matcher (e.g. `.toBe(true)`) is a no‑op and the test will always pass. Please change this to use a matcher (e.g. `expect(true).toBe(true)`) or, better, assert on the actual behavior of the code under test (outputs, return values, side effects).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1
to
+2
| test("Another truthful test", ()=>{ | ||
| expect(true) |
There was a problem hiding this comment.
issue (testing): Add a matcher to the expectation so the assertion actually runs
expect(true) without a matcher (e.g. .toBe(true)) is a no‑op and the test will always pass. Please change this to use a matcher (e.g. expect(true).toBe(true)) or, better, assert on the actual behavior of the code under test (outputs, return values, side effects).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update deployment workflow lint step naming and add an additional test file.
CI:
Tests: