Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR improves the Pages build so the generated site is more readable and more resilient to notebook authoring patterns that were rendering poorly on the live site.
Why it changed
The current Pages output still has a few visible problems:
github-markdown-cssin some browser theme combinations\textcolor{...}{...}and related color directives, which either render too faintly on the white page background or break MathJax output entirelyUser impact
The GitHub Pages site should now:
lightgray/darkgrayfragmentsImplementation notes
nbconvertruns.\textcolor{...}{...}, strips\color{...}declarations, and normalizes list-indented markdown table blocks.Validation
I validated the preprocessing directly against the affected source notebooks in this repo:
discrete-mathematics/logic/if-p-then-q-explained.ipynbdiscrete-mathematics/series-and-sequences/sum-of-cubes/sum-of-cubes-with-sum-of-squares.ipynbI also ran a repo-wide sanity check confirming the preprocessing removes all remaining
\textcolor/\color{...}directives from exported markdown cell content before conversion.I could not run a full local Pages build end-to-end in this environment because this machine still has broken local
nbconverttemplate resolution and temp-folder permission issues. The GitHub Actions Pages build on a clean runner is the expected source of truth for final validation.