Skip to content

Receiver Conditional Rendering#30

Merged
samilkk merged 7 commits into
mainfrom
cngcruz-condrender-progress
May 22, 2022
Merged

Receiver Conditional Rendering#30
samilkk merged 7 commits into
mainfrom
cngcruz-condrender-progress

Conversation

@cngcruz
Copy link
Copy Markdown
Collaborator

@cngcruz cngcruz commented May 21, 2022

Changes

  • Changed the simulation button for the WaitingForBumpSender and WaitingForBumpReceiver component
    • The blue simulation button has been removed. It has been replaced with the 'Fist Bump' image
  • Receive button now renders the WaitingForBumpReceiver component instead of immediately making the API fetch call
  • Loading spinner/progress is somewhat implemented. It is still buggy due to the conditional rendering (but I wanted to have this code pushed out there to everyone else can continue on bc spinner/progress should not be a blocker)

How to test

  1. Open 2 instances of the app (locahost for now since it is not pushed to main)
  2. On the first instance, choose the files (Sender)
  3. Press "Send Files"
  4. On the second instance, press "Receive Files"
  5. On the first instance, press the 'Fist Bump' image to send the files
  6. On the second instance, press the 'Fist Bump' to receive the files
  7. Loading spinner should show momentarily (a bit buggy at the moment due to conditional rendering)
  8. Files should populate a list and be displayed for downloading.

@cngcruz cngcruz requested a review from samilkk May 21, 2022 06:25
Copy link
Copy Markdown
Collaborator

@samilkk samilkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works great. Great job Chris!

@samilkk samilkk merged commit a8ef189 into main May 22, 2022
@cngcruz cngcruz deleted the cngcruz-condrender-progress branch May 23, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants