Skip to content

Sender uploadspeed and Receiver progress#33

Merged
samilkk merged 10 commits into
mainfrom
eric-uploadspeed
May 24, 2022
Merged

Sender uploadspeed and Receiver progress#33
samilkk merged 10 commits into
mainfrom
eric-uploadspeed

Conversation

@eric-m-truong
Copy link
Copy Markdown
Collaborator

Uploading and Downloading now display the upload speed and download progress, respectively. This makes the UI look a bit more responsive and lets the user know that the page isn't frozen.

Testing

  1. Open 2 instances of the front-end
  2. When choosing files to upload, pick a large file if you can.
  3. Larger files take longer to download/upload
  4. Larger files may also take longer to generate magnet links for, so be patient
  5. Initiate the Bump as usual
  6. Observe that the Receiver has a Progress percentage.
  7. Observe that the Sender has an Upload Speed in bytes/second

@eric-m-truong eric-m-truong requested a review from samilkk May 24, 2022 05:01
Copy link
Copy Markdown
Collaborator

@samilkk samilkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great! I tested with big and small files on both desktop and mobile. Additionally, I tried with turning off the wifi in the middle of the transfer, and the progress bar continued from where it was left. Great job!

@samilkk samilkk merged commit fac873b into main May 24, 2022
@eric-m-truong eric-m-truong deleted the eric-uploadspeed branch May 24, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants