IOS version check added to check if the device supports devicemotionevent.requestPermission() function#43
Merged
Merged
Conversation
…vent.requestPermission() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added a function that returns the function of the IOS devices.
Using that function, a version check added before asking for permission to access accelerometer data.
Testing
Just try to make a file transfer and make sure my implementation didn't affect Android and desktop devices. I tested on my older IOS, and now I get a different error on my local host. However, I don't get the error below anymore.
The new error I get on my local host is
However, I don't get this error on bambam.app. Therefore, I believe when we merge this into main, my older IOS device will be able to use our app.
If you can run my branch on bambam.app temporarily without merging it into the main branch, I may be able to test it.