add upper pin for asdf#952
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
==========================================
- Coverage 96.48% 96.16% -0.33%
==========================================
Files 95 95
Lines 6293 6340 +47
==========================================
+ Hits 6072 6097 +25
- Misses 221 243 +22 ☔ View full report in Codecov by Sentry. |
6 tasks
CagtayFabry
approved these changes
Nov 19, 2024
Member
CagtayFabry
left a comment
There was a problem hiding this comment.
Thank you @braingram , I will keep this pin for now until the next major release
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
asdf is preparing to make a 4.0.0 release. It contains a few breaking changes that will impact weldx. The major ones are:
asdf.asdf)See #910 for changes that should make weldx 4.x compatible.
This PR is an alternative which pins asdf to "<4".
Related Issues
Checks
CHANGELOG.mdtests/doc/