Skip to content

add upper pin for asdf#952

Merged
CagtayFabry merged 2 commits into
BAMWelDX:masterfrom
braingram:pin_asdf
Nov 19, 2024
Merged

add upper pin for asdf#952
CagtayFabry merged 2 commits into
BAMWelDX:masterfrom
braingram:pin_asdf

Conversation

@braingram
Copy link
Copy Markdown
Contributor

@braingram braingram commented Nov 18, 2024

Changes

asdf is preparing to make a 4.0.0 release. It contains a few breaking changes that will impact weldx. The major ones are:

  • removal of deprecated imports (like asdf.asdf)
  • switching to ASDF standard 1.6.0 as the default version when writing files

See #910 for changes that should make weldx 4.x compatible.

This PR is an alternative which pins asdf to "<4".

Related Issues

Checks

  • updated CHANGELOG.md
  • updated tests/
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@braingram braingram marked this pull request as ready for review November 18, 2024 18:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (5ad2929) to head (34c0d78).
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
- Coverage   96.48%   96.16%   -0.33%     
==========================================
  Files          95       95              
  Lines        6293     6340      +47     
==========================================
+ Hits         6072     6097      +25     
- Misses        221      243      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

Test Results

2 188 tests  ±0   2 187 ✅ ±0   1m 59s ⏱️ -6s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 34c0d78. ± Comparison against base commit 910973a.

@CagtayFabry CagtayFabry self-assigned this Nov 19, 2024
@CagtayFabry CagtayFabry self-requested a review November 19, 2024 05:56
Copy link
Copy Markdown
Member

@CagtayFabry CagtayFabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @braingram , I will keep this pin for now until the next major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants