use new pytest asdf plugin#997
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
==========================================
- Coverage 96.48% 96.30% -0.19%
==========================================
Files 95 95
Lines 6293 6328 +35
==========================================
+ Hits 6072 6094 +22
- Misses 221 234 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fefeb7f to
74a99d6
Compare
|
Converted to draft until a version of |
|
Closing and reopening to see if the conda-forge version is working. |
|
Thank you for implementing this already @braingram I assume older asdf versions will always use the older built-in plugin? |
Thanks! Yeah with any asdf < 4.4.0 the pytest-asdf-plugin will do nothing (won't register itself with pytest) so there are no conflicts from arguments, collected tests etc. With asdf 4.4.0 the bundled plugin will do nothing if it see the pytest-asdf-plugin is installed for the same reasons. The plan is to deprecate the bundled plugin (a warning will be shown during test execution only if pytest-asdf-plugin isn't already installed) and then remove it in a major version change for asdf. Let me know if you have any other questions/comments. |
Changes
Update test dependencies to use new https://pypi.org/project/pytest-asdf-plugin/ which is a feature-compatible replacement for the bundled asdf pytest plugin (which will soon be deprecated).
For context the pytest-asdf-plugin is responsible for finding and converting schema files into "tests" (to check the schema against the metaschema and validated any contained "examples"). Since both the bundled and now external plugins are feature-compatible there should be no change in test number (or new failures, etc).
On main 153 tests passed:
https://github.com/BAMWelDX/weldx/actions/runs/17033022164/job/48279380582#step:7:130
With this PR 153 tests passed:
https://github.com/BAMWelDX/weldx/actions/runs/17050088327/job/48335364972?pr=997#step:7:130
Checks
CHANGELOG.mdtests/doc/