Skip to content

use new pytest asdf plugin#997

Merged
CagtayFabry merged 2 commits into
BAMWelDX:masterfrom
braingram:pytest_asdf_plugin
Aug 20, 2025
Merged

use new pytest asdf plugin#997
CagtayFabry merged 2 commits into
BAMWelDX:masterfrom
braingram:pytest_asdf_plugin

Conversation

@braingram
Copy link
Copy Markdown
Contributor

@braingram braingram commented Aug 18, 2025

Changes

Update test dependencies to use new https://pypi.org/project/pytest-asdf-plugin/ which is a feature-compatible replacement for the bundled asdf pytest plugin (which will soon be deprecated).

For context the pytest-asdf-plugin is responsible for finding and converting schema files into "tests" (to check the schema against the metaschema and validated any contained "examples"). Since both the bundled and now external plugins are feature-compatible there should be no change in test number (or new failures, etc).

On main 153 tests passed:
https://github.com/BAMWelDX/weldx/actions/runs/17033022164/job/48279380582#step:7:130

With this PR 153 tests passed:
https://github.com/BAMWelDX/weldx/actions/runs/17050088327/job/48335364972?pr=997#step:7:130

Checks

  • updated CHANGELOG.md
  • updated tests/
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 18, 2025

Test Results

2 188 tests  ±0   2 187 ✅ ±0   2m 24s ⏱️ +8s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c96fa02. ± Comparison against base commit 003be28.

♻️ This comment has been updated with latest results.

@braingram braingram marked this pull request as ready for review August 18, 2025 19:20
@braingram

This comment was marked as outdated.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.30%. Comparing base (5ad2929) to head (c96fa02).
⚠️ Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
- Coverage   96.48%   96.30%   -0.19%     
==========================================
  Files          95       95              
  Lines        6293     6328      +35     
==========================================
+ Hits         6072     6094      +22     
- Misses        221      234      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as draft August 18, 2025 20:49
@braingram
Copy link
Copy Markdown
Contributor Author

Converted to draft until a version of pytest-asdf-plugin is on conda forge.

xref: conda-forge/staged-recipes#30820

@braingram
Copy link
Copy Markdown
Contributor Author

Closing and reopening to see if the conda-forge version is working.

@braingram braingram closed this Aug 18, 2025
@braingram braingram reopened this Aug 18, 2025
@braingram braingram marked this pull request as ready for review August 19, 2025 00:17
@CagtayFabry
Copy link
Copy Markdown
Member

Thank you for implementing this already @braingram

I assume older asdf versions will always use the older built-in plugin?

@CagtayFabry CagtayFabry enabled auto-merge (squash) August 20, 2025 08:18
@CagtayFabry CagtayFabry merged commit e746f58 into BAMWelDX:master Aug 20, 2025
26 checks passed
@braingram braingram deleted the pytest_asdf_plugin branch August 20, 2025 10:59
@braingram
Copy link
Copy Markdown
Contributor Author

Thank you for implementing this already @braingram

I assume older asdf versions will always use the older built-in plugin?

Thanks!

Yeah with any asdf < 4.4.0 the pytest-asdf-plugin will do nothing (won't register itself with pytest) so there are no conflicts from arguments, collected tests etc. With asdf 4.4.0 the bundled plugin will do nothing if it see the pytest-asdf-plugin is installed for the same reasons. The plan is to deprecate the bundled plugin (a warning will be shown during test execution only if pytest-asdf-plugin isn't already installed) and then remove it in a major version change for asdf.

Let me know if you have any other questions/comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants