1 polish the structure of the repo and add nextjs generated gui #2

KoeppelSoftwareEngineer · 2025-12-03T12:28:24Z

Description Message, I am creating a "Pull Request".

…t.toml

coveralls · 2025-12-03T13:35:40Z

Pull Request Test Coverage Report for Build 20022565851

Details

0 of 51 (0.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage	Changed/Added Lines	%
backend/database.py	4	0.0%
backend/datamodel.py	10	0.0%
backend/main.py	37	0.0%

Totals
Change from base Build 19474966801:	0.0%
Covered Lines:	0
Relevant Lines:	65

💛 - Coveralls

JosePizarro3

Some minor comments. I will go through installing this locally, checking the README, and let you know how it goes.

I didn't review the frontend. Once I launch this I will take a look and give some comments.

backend/_version.py

backend/database.py

backend/datamodel.py

backend/main.py

backend/model.py

backend/database.py

backend/main.py

README.md

…like a charm

JosePizarro3

just some minor comments, I will rewrite the README later

JosePizarro3 · 2025-12-05T06:52:28Z

backend/datamodel.py

+    )
+
+
+class UpdateSchema(BaseModel):


why do you need this?

This model is typically used for partial updates (think HTTP PATCH): you want to allow the client to send only the fields that change, not the entire schema.

SchemaDefinition describes a full object (all required fields).
UpdateSchema describes a partial object where fields are optional so you can update only name, only version, or both.

ah wait, then what needs to change to have optional fields in SchemaDefinition, so you can delete UpdateSchema. So this file content can be:

from datetime import datetime from pydantic import BaseModel, Field class SchemaDefinition(BaseModel): id: str = Field(..., description="Unique identifier for the schema") name: str | None = Field( None , description="Human-readable name of the schema", min_length=3, ) version: str | None = Field(None, description="Version of the schema") content: dict | None = Field(None, description="The actual schema content as a dictionary") updated_at: datetime | None = Field( None, description="Timestamp of the last update" )

as you see, I only defined one class SchemaDefinition

Changes applied

JosePizarro3 · 2025-12-05T06:54:19Z

backend/main.py

+    schema_documents = list(schemas_collection.find())
+
+    # Verbose loop: clarify what we're iterating over and why
+    for schema_document in schema_documents:


to be honest, I am not sure what this logic does. You get the original_id from schema_document["_id"] and then you overwrite schema_document["_id"] with the original_id (which is already a string, shouldn't mutate to another type at any moment)

I think this method just needs to return list(schemas_collection.find())

I can just take your suggestion -->> return list(schemas_collection.find())

BUT there could be issures with that: you shouldn’t return list(schemas_collection.find()) directly.
It will most likely raise TypeError: ObjectId is not JSON serializable because MongoDB’s _id field is a bson.ObjectId, not a string. FastAPI’s default JSON encoder doesn’t know how to serialize ObjectId.
Why it fails

Each document contains "_id": ObjectId(...).
When FastAPI tries to serialize the list, it encounters the ObjectId and crashes.

okay; I have updated "get_all_schemas" in a different way. with: 1) jsonable_encoder with custom encoder
Best for: Typical REST APIs; teams using OpenAPI tooling; frontends that expect plain JSON strings for IDs.
Pros - One-liner conversion for _id and any nested ObjectIds.
- Plays nicely with FastAPI’s response models and OpenAPI schema.
- Keeps output stable (e.g., "_id": "656f...") and easy to consume.
Cons - You still need to define encoders for other BSON types if you use them (e.g., Decimal128, Binary).

I am confused now; why the ID needs to be of type bson? is there some benefits to this?

backend/main.py

KoeppelSoftwareEngineer · 2025-12-05T07:52:44Z

Nice

…T API responses

JosePizarro3

There is an easier way of handling IDs, which is with hashlib. This way we will get rid of bson types.

I can implement that, but for you, perhaps is a good idea to simply assume that ìdis astr, and do not use ObjectIdfor any of thebackend/main.py` implementations.Once you get rid of these, I will take over and finish this pull request by implementing the handling of hashes for ids (so you can easily see what I mean).

So, in short:

Go through my final comments
Delete ObjectId usage and simply assume id is a string you can safely use
Let me know by asking me to re-review
I handled the id situation with hashes
You take a look
We merge

JosePizarro3 · 2025-12-08T12:19:56Z

backend/main.py

+
+# ---- Routes ----
+@app.get("/schemas")
+async def get_all_schemas() -> List[Dict[str, Any]]:


ruff fails because you should be using: list[dict[str, Any]] and no need to import typing classes like Dict, or List. Same goes for other app functions

JosePizarro3 · 2025-12-08T12:21:23Z

backend/main.py

+
+    # Insert and obtain new ObjectId
+    result = schemas_collection.insert_one(schema.dict())
+    inserted_oid = result.inserted_id


mmm what are all these lines after insering the schema?

JosePizarro3 · 2025-12-08T12:22:32Z

backend/datamodel.py

-    version: str
-    content: dict  # JSON schema
-    updated_at: datetime
+    id: str = Field(..., description="Unique identifier for the schema")


I have another suggestion for ID: using hashlib instead and create a hash depending on the schema.dict() content.

this way we get rid off bson types

JosePizarro3 · 2025-12-08T12:23:37Z

backend/main.py

+    if result.matched_count == 0:
+        raise HTTPException(status_code=404, detail="Schema not found")
+
+    # Optionally return the updated document (commented out by default)


normally you should delete "dead code", without leaving it in the src code of your apps

means: delete these lines (from 104 to 109)

GorkiPower added 13 commits November 28, 2025 13:23

NO change in version.py

cfa3505

add main.py; add model.py

4c3e908

add: from datetime import datetime

9cc70a9

add simple FARM-Stack

8681ea8

Ready to start -> uvicorn backend.main:app --reload

621e3fd

add

65b4a20

frontend is working without 404 Not Found

6f58f29

Add Next.js frontend

efebed4

Starting Clean Backend Frontend NOT working together

4cf11e4

Server are NOT TALKING TO EACH OTHER

ca11ef8

Server a running - Frontend and Backend are NOT communiating

4494a01

Update REAMDE

32f49ac

Updated README

1568c6d

KoeppelSoftwareEngineer linked an issue Dec 3, 2025 that may be closed by this pull request

Polish the structure of the repo and add NextJS generated GUI #1

Open

4 tasks

KoeppelSoftwareEngineer requested a review from JosePizarro3 December 3, 2025 12:34

GorkiPower added 2 commits December 3, 2025 14:27

ruff check .; ruff check . --fix; ruff format .; Add Ruff to pyprojec…

8f057e1

…t.toml

Update pyproject.toml

6ebd4f7

GorkiPower added 2 commits December 3, 2025 14:42

Update: backend/_version.py

e83a983

Apply Ruff formatting

297ddf2

JosePizarro3 reviewed Dec 3, 2025

View reviewed changes

GorkiPower added 9 commits December 3, 2025 15:58

Update database.py, datamodel.py, main.py, model.py

f5dacc3

Updated datamodel.py main.py model.py

05c1ce3

run ruff check . --fix and ruff format .

dcbf01e

clean model.py

1a728af

bugs are fixed - ruff is happy

eb80f2f

Merging model.py and datamodel.py has led to challenges :D Works now …

5c597aa

…like a charm

Clean all the rubbish

be2ef20

delete model.py

78a303e

Update: main before more verbose

fda8f59

GorkiPower added 2 commits December 3, 2025 17:22

It works fine

db59966

BugFix: ruff check . --fix; ruff format .

b8d2af9

KoeppelSoftwareEngineer requested a review from JosePizarro3 December 4, 2025 09:44

JosePizarro3 approved these changes Dec 5, 2025

View reviewed changes

GorkiPower added 2 commits December 8, 2025 09:28

Update main.py

46c4338

feat: use jsonable_encoder with custom ObjectId encoder for clean RES…

158dff2

…T API responses

JosePizarro3 requested changes Dec 8, 2025

View reviewed changes

1 polish the structure of the repo and add nextjs generated gui #2

Are you sure you want to change the base?

1 polish the structure of the repo and add nextjs generated gui #2

Conversation

KoeppelSoftwareEngineer commented Dec 3, 2025

Uh oh!

coveralls commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 20022565851

Details

💛 - Coveralls

Uh oh!

JosePizarro3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JosePizarro3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JosePizarro3 Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KoeppelSoftwareEngineer commented Dec 5, 2025

Uh oh!

JosePizarro3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Dec 3, 2025 •

edited

Loading

JosePizarro3 Dec 8, 2025 •

edited

Loading